Skip to content

Conversation

@KeithYeh
Copy link
Contributor

Description

cosmiconfig have been upgrade to 9.0.0 in #4062
But there is a breaking change in cosmiconfig 9.0.0
See https://github.com/cosmiconfig/cosmiconfig/blob/main/CHANGELOG.md#900

Breaking change: This is the default value if you don't pass a stopDir option, which means that cosmiconfig no longer traverses directories by default, and instead just looks in the current working directory.
If you want to achieve maximum backwards compatibility without adding an explicit stopDir, add the searchStrategy: 'global' option.

Any lerna commands run in subdirectories are broken now.

Motivation and Context

Fix issue #4118

How Has This Been Tested?

Run npm test && npm run integration

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link

nx-cloud bot commented Mar 12, 2025

View your CI Pipeline Execution ↗ for commit 0943cfc.

Command Status Duration Result
nx run-many --t e2e --parallel=1 ✅ Succeeded 11m 15s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded 1m 31s View ↗
nx run-many -t lint --parallel=3 ✅ Succeeded 1m 19s View ↗
nx run-many -t build --parallel=3 ✅ Succeeded 1m 13s View ↗
nx run integration:integration --ci --maxWorkers=2 ✅ Succeeded 17s View ↗
nx run-many -t build ✅ Succeeded 4s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 3s View ↗
nx run-many -t test --parallel=3 --ci --maxWork... ✅ Succeeded 4m 41s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-12 10:54:59 UTC

@JamesHenry
Copy link
Member

Thanks @KeithYeh! Looks like you need to update the formatting please

@KeithYeh
Copy link
Contributor Author

@JamesHenry I have fixed the formatting issue. Please review.

@JamesHenry JamesHenry merged commit 6242511 into lerna:main Mar 12, 2025
13 checks passed
@JamesHenry
Copy link
Member

Thanks again @KeithYeh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants