Skip to content

Conversation

@msobiecki
Copy link
Contributor

@msobiecki msobiecki commented Jul 7, 2024

Description

This pull request introduces the truncateReleaseBody function, which ensures that release body content does not exceed the specified maximum length for GitHub and GitLab release descriptions, thereby preventing errors.

Motivation and Context

#3833

How Has This Been Tested?

#3833

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@msobiecki msobiecki changed the title feat: add release body limit feat: add create release body limit Jul 7, 2024
@nx-cloud
Copy link

nx-cloud bot commented Jul 24, 2024

@MaolmeoX
Copy link

I'm interested in this pull request for a project. I'm stuck with a message from Github saying that the body of the request exceeds the limit of 125,000 characters. The issue arises because I'm moving from an independent versioning mode to a fixed versioning mode, and the changelog of all the changes since the last release is quite substantial and exceeds the limit.

@ghiscoding
Copy link

I'm interested in this pull request for a project. I'm stuck with a message from Github saying that the body of the request exceeds the limit of 125,000 characters. The issue arises because I'm moving from an independent versioning mode to a fixed versioning mode, and the changelog of all the changes since the last release is quite substantial and exceeds the limit.

I guess a bypass for you in that use case might be to separate/rename your old changelogs, for example the esbuild project is renaming their changelogs on every new year. Though I understand that might also mean a lot of package/changelog to rename, but anyway just wanted to give an option in case it was a blocker for you at the moment

@JamesHenry JamesHenry changed the title feat: add create release body limit fix(version): truncate release body based on maximum size of VCS client Aug 5, 2024
@JamesHenry
Copy link
Member

Thanks @msobiecki! I have updated the PR description to what I feel better matches what this change does, I view it as a fix to the version command

@JamesHenry JamesHenry merged commit 3c2a3c9 into lerna:main Aug 5, 2024
@JamesHenry JamesHenry changed the title fix(version): truncate release body based on maximum size of VCS client fix(version): truncate release body based on maximum size allowed by VCS client Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants