Skip to content

Conversation

@Myastr0
Copy link

@Myastr0 Myastr0 commented Jul 5, 2024

Add possibility to provide a filepath to the --summary-file option in the publish command

Description

This PR introduces a new capability to the Lerna library, allowing users to specify a filepath instead of a directory path for the --summary-file option.

Previously, users could only provide a directory path and the created filename is statically defined in the code as lerna-publish-summary.json , which limited the flexibility in defining the location and name of the summary file.

Motivation and Context

With this change, users can now directly specify the full path, including the filename, where the summary should be saved.

How Has This Been Tested?

In the publish-command.spec.ts file, adding a new test case where a filepath is passed as input parameter.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@JamesHenry JamesHenry changed the title feat(publish command): add new --summary-file capability feat(publish): support full file path for --summary-file Jul 24, 2024
@nx-cloud
Copy link

nx-cloud bot commented Jul 24, 2024

@ghiscoding
Copy link

@Myastr0 I'm assuming your PR probably won't be accepted from the Lerna team until you fix the linting issue shown in the report above. Cheers

@Myastr0
Copy link
Author

Myastr0 commented Aug 8, 2024

@Myastr0 I'm assuming your PR probably won't be accepted from the Lerna team until you fix the linting issue shown in the report above. Cheers

Okey, let me fix it so !

@Myastr0
Copy link
Author

Myastr0 commented Aug 8, 2024

@ghiscoding , I should be good now, who I have to ping to rerun the Nx cloud jobs ?

@JamesHenry
Copy link
Member

JamesHenry commented Aug 8, 2024

@Myastr0 It looks like you have legitimate failures still, are you running the changes locally before pushing? Is your local somehow disagreeing with CI?

@Myastr0
Copy link
Author

Myastr0 commented Aug 13, 2024

@Myastr0 It looks like you have legitimate failures still, are you running the changes locally before pushing? Is your local somehow disagreeing with CI?

Sorry @JamesHenry I didn't see your response here, I made some changes on the implementation and create a dedicated fn to get summaryFilePath based on the provided option + fix the tests related to this feature

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Myastr0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants