-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(publish): support full file path for --summary-file #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 30c2d1e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following target is in progress ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
|
@Myastr0 I'm assuming your PR probably won't be accepted from the Lerna team until you fix the linting issue shown in the report above. Cheers |
Okey, let me fix it so ! |
|
@ghiscoding , I should be good now, who I have to ping to rerun the Nx cloud jobs ? |
|
@Myastr0 It looks like you have legitimate failures still, are you running the changes locally before pushing? Is your local somehow disagreeing with CI? |
…epath insteadof directory path
Sorry @JamesHenry I didn't see your response here, I made some changes on the implementation and create a dedicated fn to get summaryFilePath based on the provided option + fix the tests related to this feature |
JamesHenry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Myastr0!
Add possibility to provide a filepath to the
--summary-fileoption in the publish commandDescription
This PR introduces a new capability to the Lerna library, allowing users to specify a filepath instead of a directory path for the
--summary-fileoption.Previously, users could only provide a directory path and the created filename is statically defined in the code as
lerna-publish-summary.json, which limited the flexibility in defining the location and name of the summary file.Motivation and Context
With this change, users can now directly specify the full path, including the filename, where the summary should be saved.
How Has This Been Tested?
In the
publish-command.spec.tsfile, adding a new test case where a filepath is passed as input parameter.Types of changes
Checklist: