☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03dd83f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

Sent with 💌 from NxCloud.

@JamesHenry I changed the behaviour of --amend in combination with --message so that the message will be overrridden if specified. I think this is a breaking change and therefore not a good solution.

What do you think about using another flag like --amendMessage to support amending and overriding the message in one go?

@fahslaj what do you think?

Hey @amorscher , I think it's fine to update --amend and --message to behave as you stated at first, where passing them both together will properly override the message. It would technically be a breaking change, but I think that this is really a bug fix and that most users would expect --amend and --message to work together anyway.

Hi @amorscher just following up on the latest plans for this PR please

Please feel to reopen this whenever you have chance to work on it, but I'll close it for now for clarity, thanks again

@fahslaj @JamesHenry Sorry for the delay. I was working on it again but it looks like i am missing rights to reopen the PR

@amorscher No problem, you made some more changes after that comment, but should I infer that this is now ready for review again?

@JamesHenry yes it should be ready for review.

Thanks again @amorscher!