-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Using conventionalcommits as changelogPreset causes lerna version to do nothing #3871
Description
Current Behavior
Appium has a lerna.json that has the following field:
{
"changelogPreset": "conventional-changelog-conventionalcommits"
}Up until the v7 release of conventional-changelog, this worked as expected. After upgrading to v7+, the lerna version process exits immediately (with zero exit code) after loading the conventionalcommits package, rather than proceeding with the versioning process.
I originally reported this to the other project as conventional-changelog/conventional-changelog#1157, but the maintainers there mentioned it is up to Lerna to update its use of conventionalcommits to reflect the breaking changes that have happened there.
I'm currently working around this issue by keeping the version of conventional-changelog-conventionalcommits pinned to 6.1.0.
Expected Behavior
I expect that using this changelogPreset setting will result in the version suggestion dialog instead of Lerna exiting.
Steps to Reproduce
- Clone https://github.com/appium/appium.git
npm installnpm install --save conventional-changelog-conventionalcommits@latestnpx lerna version
Environment
lerna notice cli v7.4.1
lerna info versioning independent
Environment info:
System:
OS: macOS 12.6.7
CPU: (10) arm64 Apple M1 Pro
Binaries:
Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
Yarn: 1.22.19 - ~/Code/gh/appium/appium/node_modules/.bin/yarn
npm: 10.1.0 - ~/.nvm/versions/node/v18.17.0/bin/npm
Utilities:
Git: 2.39.0 - /opt/homebrew/bin/git
npmPackages:
lerna: 7.4.1 => 7.4.1