Skip to content

Bug: Conventional commits do not respect '!' or "BREAKING CHANGE" #2668

@alexforsyth

Description

@alexforsyth

Lerna conventional commits do not respect '!' as denoting a breaking change when part of the 'types' on a conventional commit. Additionally, It seems like including the '!' may make lerna not recognize that commit as a valid conventional commit in some cases. This repo also highlights this problem.

EDIT: Looks like “BREAKING CHANGE:” is also not being respected.

Repro repo:
https://github.com/alexforsyth/lerna-conventional-commits

Expected Behavior

The generated changelog should list breaking changes, when a '!' is included on a type.

ex. 2 from conventional commits

refactor!: drop support for Node 6

Should be equal to using the BREAKING CHANGE: phrase in the footer.

Current Behavior

The generated changelog does not include the change when '!' is included on a type.

ex.

refactor!: drop support for Node 6

Possible Solution

Steps to Reproduce (for bugs)

This repo is a live example that highlights this problem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions