fix(publish): OTP cache should be seeded from conf value, not CLI directly

evocateur · evocateur · commit cf56622db87d · 2019-07-16T10:06:11.000-07:00
diff --git a/commands/publish/index.js b/commands/publish/index.js
@@ -90,9 +90,6 @@ class PublishCommand extends Command {
     this.logger.verbose("session", npmSession);
     this.logger.verbose("user-agent", userAgent);
 
-    // cache to hold a one-time-password across publishes
-    this.otpCache = { otp: this.options.otp };
-
     this.conf = npmConf({
       lernaCommand: "publish",
       npmSession,
@@ -101,6 +98,9 @@ class PublishCommand extends Command {
       registry: this.options.registry,
     });
 
+    // cache to hold a one-time-password across publishes
+    this.otpCache = { otp: this.conf.get("otp") };
+
     this.conf.set("user-agent", userAgent, "cli");
 
     if (this.conf.get("registry") === "https://registry.yarnpkg.com") {
