Added UMD support#12
Merged
Merged
Conversation
Contributor
Author
|
Whoops! Just realized I had the wrong global namespace in there—just pushed a quick fix. |
|
@tannerhodges thanks for the fix! Fingers crossed it gets merge soon |
|
This is still open from Jan 22. This is definitely worth having. What's the outcome? |
Owner
|
I honestly forgot to progress on this. I'll get it done this weekend. |
|
Hi,
and it appears I've reverted to v1.0.2 and that appears to work fine. |
Owner
|
That's a case-sensitivity issue. You'll need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went to use this with noUiSlider and realized that
require('wnumb')was returning an empty object, so I copied the UMD patten from noUiSlider.Hope this is a quick fix for anyone else out there using Browserify.