Merged
Conversation
lemire
reviewed
Dec 7, 2022
include/fast_double_parser.h
Outdated
| #elif defined(_WIN32) | ||
| static _locale_t c_locale = _create_locale(LC_ALL, "C"); | ||
| *outDouble = _strtod_l(ptr, &endptr, c_locale); | ||
| #else |
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestions. This looks better. :-). Pushed the new code. thanks.
Owner
|
I think it passes our tests. I'd like you to answer my question regarding |
Contributor
Author
|
Thanks @lemire do you know how can we make sure it goes into next fixpack/release ? and BTW, do you know what's the next fixpack schedule ? You know , this change is mostly for the lightGBM on our system. With this released, we need to do update for lightGBM then. thanks. |
Contributor
Author
|
looks nice. thanks @lemire |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is for the support of IBM i/PASE env. Could you help to review and kindly merge? Thanks.
NOTE: macro PASE is special for our system,and would not break your project on other platforms.