Use AX_ADD_FORTIFY_SOURCE to avoid redefining _FORTIFY_SOURCE#103
Merged
legionus merged 1 commit intolegionus:masterfrom Oct 8, 2023
Merged
Use AX_ADD_FORTIFY_SOURCE to avoid redefining _FORTIFY_SOURCE#103legionus merged 1 commit intolegionus:masterfrom
AX_ADD_FORTIFY_SOURCE to avoid redefining _FORTIFY_SOURCE#103legionus merged 1 commit intolegionus:masterfrom
Conversation
Owner
|
@thesamesam This seems generally correct and useful. But your change breaks distcheck: |
Contributor
Author
|
Thanks. I can't seem to reproduce it locally yet, although I think I can see how it might happen with the -Werror mangling. I'm going to switch to |
Owner
|
I found the problem. The problem is not that -Werror is used, but that the |
Some distributions are now setting -D_FORTIFY_SOURCE=3 by default in their toolchains rather than _F_S=2. By forcing _F_S=2, this causes both a warning and a downgrade in the effective protection. Use the autoconf-archive macro for this purpose (AX_ADD_FORTIFY_SOURCE) to add the fortification at the highest supported level if the compiler doesn't already default to it. Bug: https://bugs.gentoo.org/892834 Signed-off-by: Sam James <sam@gentoo.org>
Contributor
Author
|
Thanks for the help - sorry it wasn't as straightforward as it was supposed to be. |
Owner
|
Thank you! Applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some distributions are now setting -D_FORTIFY_SOURCE=3 by default in their toolchains rather than _F_S=2. By forcing _F_S=2, this causes both a warning and a downgrade in the effective protection.
Use the autoconf-archive macro for this purpose (AX_ADD_FORTIFY_SOURCE) to add the fortification at the highest supported level if the compiler doesn't already default to it.