Skip to content

Fixed imputer shape bug#2

Merged
TayyabDev merged 2 commits intomainfrom
issue-19352
Mar 6, 2021
Merged

Fixed imputer shape bug#2
TayyabDev merged 2 commits intomainfrom
issue-19352

Conversation

@TayyabDev
Copy link
Copy Markdown
Collaborator

Fixed issue 19352 from sci-kit learn.

@TayyabDev
Copy link
Copy Markdown
Collaborator Author

Working on adding tests

Copy link
Copy Markdown
Collaborator

@davidhjh davidhjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Collaborator

@Tanaan98 Tanaan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@TayyabDev
Copy link
Copy Markdown
Collaborator Author

Added the test case, you can test it out using:

python -m pytest -v sklearn/impute/tests/test_impute.py::test_imputer_reshape

@TayyabDev TayyabDev merged commit a4d86c7 into main Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interactive Imputer cannot accept PLSRegression() as an estimator due to "shape mismatch"

4 participants