Adding persistent option to has_settings#99
Merged
ledermann merged 1 commit intoledermann:masterfrom Aug 22, 2019
nicolaiespresso:master
Merged
Adding persistent option to has_settings#99ledermann merged 1 commit intoledermann:masterfrom nicolaiespresso:master
ledermann merged 1 commit intoledermann:masterfrom
nicolaiespresso:master
Conversation
Owner
|
Looks good to me, thanks. Just one thing: Please remove the version number change. |
Contributor
Author
|
Ok, just reverted the version file. |
Owner
|
Merged. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for the great work with this gem. It is very useful for us.
In my project, I need to define some settings in a Concern and then another set of settings in the model. Currently, the configuration class resets the default_settings in every has_settings call.
To allow settings additions I added a persistent option. I realize the code could be better. However, initially, I would like you to analyze if this type of solution is acceptable.
Thanks again.