Fix mutable default settings bug#109
Merged
ledermann merged 5 commits intoledermann:masterfrom Mar 3, 2022
Merged
Conversation
Owner
|
Great find and great documentation, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #108.
RailsSettings::SettingObject#_get_valueso that it returns a "deep dup" of the default value, as opposed to a direct reference to the default value.How to test
Pull in
RailsSettings::SettingObjectfrommasterand run tests:The new tests fail (along with an additional test that is affected by this, since
User.default_settingsgets modified).Alternatively, you can use the code in the issue referenced above to reproduce.
Notes
This approach to using
Marshalto deep dup an object is documented in the book "The Ruby Programming Language" (page 83):Flanagan, David. The Ruby Programming Language. “O’Reilly Media, Inc.,” 2008.