Skip to content

fix(message-signing): signature defaulting to rsv order#2429

Closed
kyranjamie wants to merge 1 commit intodevfrom
fix/sig-formatting-rsv
Closed

fix(message-signing): signature defaulting to rsv order#2429
kyranjamie wants to merge 1 commit intodevfrom
fix/sig-formatting-rsv

Conversation

@kyranjamie
Copy link
Copy Markdown
Contributor

@kyranjamie kyranjamie commented May 17, 2022 •
edited by github-actions bot
Loading

Try out this version of the Hiro Wallet - download extension builds.

Per @MarvinJanssen's comment in #2419, this defaults the signature to rsv order.

Alternatively, we could return both? I wonder if that's a better solution?

cc/ @pradel @aulneau

@vercel
Copy link
Copy Markdown

vercel bot commented May 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
stacks-wallet-web ✅ Ready (Inspect) Visit Preview May 17, 2022 at 1:21PM (UTC)

@vercel vercel bot temporarily deployed to Preview May 17, 2022 12:47 Inactive
@markmhendrickson markmhendrickson linked an issue May 17, 2022 that may be closed by this pull request
Signed messages should return a signature that has recoverable public key #2419
Closed
@pradel
Copy link
Copy Markdown
Contributor

pradel commented May 17, 2022

@kyranjamie, would it make more sense to change the signWithKey function in the stacks.js package instead? As most developers will use the signWithKey and publicKeyFromSignature exported from stacks.js which would remove the need to change the order in every codebase when someone integrates these functions.

@kyranjamie kyranjamie force-pushed the fix/sig-formatting-rsv branch from 752e4b6 to 349db47 Compare May 17, 2022 13:12
@vercel vercel bot temporarily deployed to Preview May 17, 2022 13:12 Inactive
@kyranjamie kyranjamie force-pushed the fix/sig-formatting-rsv branch from 349db47 to 0512578 Compare May 17, 2022 13:21
@vercel vercel bot temporarily deployed to Preview May 17, 2022 13:21 Inactive
@aulneau
Copy link
Copy Markdown
Contributor

aulneau commented May 17, 2022

@kyranjamie, would it make more sense to change the signWithKey function in the stacks.js package instead? As most developers will use the signWithKey and publicKeyFromSignature exported from stacks.js which would remove the need to change the order in every codebase when someone integrates these functions.

I would say this makes most sense versus returning both. I think this is more of a standards issue than anything else. We just need to be explicit about why and how to use this.

@pradel pradel mentioned this pull request May 19, 2022
Closed
9 tasks
@janniks janniks mentioned this pull request May 23, 2022
Merged
@beguene
Copy link
Copy Markdown
Contributor

beguene commented Jun 10, 2022

Closing this in favour of #2484

@beguene beguene closed this Jun 10, 2022
@pete-watters pete-watters deleted the fix/sig-formatting-rsv branch February 14, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Signed messages should return a signature that has recoverable public key

4 participants

@kyranjamie @pradel @aulneau @beguene