Improve SendToFlutter platform checks #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly intended to fix #51, but also includes some additional cleanup.
The error in #51 is caused by platform specific iOS code that doesn't work in the Play mode of the Unity Editor.
This can easily be fixed by checking for NOT editor.
While updating this, I noticed Android uses a runtime check instead of compile-time.
So I combined both checks into
#if and #eliflogic.In short:
#if UNITY_IOScheck by checking forUNITY_EDITORfirst.Application.platform == RuntimePlatform.Androidwith#if UNITY_ANDROIDfor efficiency.SendToFlutter.Send()is called in the Unity Editor, to show the function does something.The changes are identical for Unity 2022_3 and 6000_0