Closed
Conversation
In preparation for splitting that file.
- 300 further lines still to split off - need to add/update main docstrings - also need to adjust other imports (explode and shake?).
…unity/mathlib4 into MR-split-ennreal
|
This PR/issue depends on: |
j-loreaux
reviewed
Jan 20, 2024
Contributor
j-loreaux
left a comment
There was a problem hiding this comment.
I suggest you try to keep the git history as clean as possible on this one (even rebase locally before pushing if need be), that way reviewers can follow along by commit to see what moved where.
Contributor
Author
|
I just rebased all commits, creating a new branch |
Contributor
Author
|
Closing in favour of #9869, which has the same commits (up to dropping the import fixups, merging etc.) and adresses the review comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.