chore (Algebra.Basic): make RingHom.id and related declarations reducible #9025
Closed
mattrobball wants to merge 11 commits intomasterfrom
Closed
chore (Algebra.Basic): make RingHom.id and related declarations reducible #9025mattrobball wants to merge 11 commits intomasterfrom
RingHom.id and related declarations reducible #9025mattrobball wants to merge 11 commits intomasterfrom
Conversation
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit ca5cf29. Benchmark Metric Change
=================================================================================
- build instructions 5.7%
- build simp 29.6%
- build wall-clock 8.2%
- ~Mathlib.Algebra.Lie.BaseChange instructions 2789.9%
- ~Mathlib.Algebra.Lie.Killing instructions 211.7%
- ~Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Scheme instructions 52.3%
- ~Mathlib.Analysis.Calculus.LagrangeMultipliers instructions 383.8%
- ~Mathlib.Analysis.InnerProductSpace.Adjoint instructions 3.9%
- ~Mathlib.Analysis.NormedSpace.Extend instructions 154.7%
- ~Mathlib.Analysis.NormedSpace.Multilinear.Basic instructions 3.6%
- ~Mathlib.Analysis.SpecialFunctions.PolarCoord instructions 467.2%
- ~Mathlib.Analysis.SpecialFunctions.Pow.Deriv instructions 369.1%
- ~Mathlib.Data.Polynomial.Derivation instructions 131.0%
- ~Mathlib.Geometry.Manifold.Instances.Sphere instructions 5.0%
- ~Mathlib.LinearAlgebra.AffineSpace.AffineMap instructions 29.2%
- ~Mathlib.LinearAlgebra.Basis instructions 594.4%
- ~Mathlib.LinearAlgebra.BilinearForm.Hom instructions 52.9%
- ~Mathlib.LinearAlgebra.Matrix.BilinearForm instructions 304.7%
- ~Mathlib.LinearAlgebra.Matrix.SesquilinearForm instructions 217.5%
- ~Mathlib.LinearAlgebra.Prod instructions 159.5%
- ~Mathlib.RepresentationTheory.Character instructions 803.6%
- ~Mathlib.RepresentationTheory.GroupCohomology.Basic instructions 53.3%
- ~Mathlib.RepresentationTheory.GroupCohomology.Resolution instructions 2.9%
- ~Mathlib.RingTheory.PowerSeries.Basic instructions 28.8% |
eric-wieser
reviewed
Dec 13, 2023
Mathlib/Algebra/Algebra/Basic.lean
Outdated
Comment on lines
+434
to
+435
| instance id : Algebra R R := | ||
| @[reducible] instance id : Algebra R R := |
Member
There was a problem hiding this comment.
I thought the whole point in instance is that it's reducible enough for anything typeclass related?
Member
There was a problem hiding this comment.
Do you have a mwe to demo that?
(I agree with the principle behind the rest of this PR to change the non-instances to be reducible)
Contributor
Author
There was a problem hiding this comment.
Ah processing what you are saying now. You are correct, that is silly.
Algebra.id, RingHom.id, MonoidHom.id reducible RingHom.id and related declarations reducible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These instances often appear as parameters to typeclass instances that need to unify reducibly.