chore (Pi.Algebra): Change a binder from instance implicit to implicit #9020
Closed
mattrobball wants to merge 1 commit intomasterfrom
Closed
chore (Pi.Algebra): Change a binder from instance implicit to implicit #9020mattrobball wants to merge 1 commit intomasterfrom
mattrobball wants to merge 1 commit intomasterfrom
Conversation
Member
|
I think this is the wrong solution to the diagnosed problem, so I would prefer not to merge this unless you have independent reasons for wanting this. |
Contributor
Author
|
To be clear, I am not strongly advocating for anything currently. I want to check breakage and performance implications at the moment. |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 7e4e3da. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following @kmill's suggestion on Zulip, we change the instance implicit binder on the troublesome
Pi.smul_applyto implicit.