Skip to content

chore: generalize LieSubalgebra.mem_map_submodule#7994

Open
ericrbg wants to merge 4 commits intomasterfrom
ericrbg/todo2
Open

chore: generalize LieSubalgebra.mem_map_submodule#7994
ericrbg wants to merge 4 commits intomasterfrom
ericrbg/todo2

Conversation

@ericrbg
Copy link
Copy Markdown
Contributor

@ericrbg ericrbg commented Oct 28, 2023


Not sure if we should rename to something like mem_map_iff_mem_map_submodule or not.

Open in Gitpod

@ericrbg ericrbg added awaiting-review awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Oct 28, 2023
@ericrbg ericrbg mentioned this pull request Oct 28, 2023
theorem mem_map_submodule (e : L ≃ₗ⁅R⁆ L₂) (x : L₂) :
x ∈ K.map (e : L →ₗ⁅R⁆ L₂) ↔ x ∈ (K : Submodule R L).map (e : L →ₗ[R] L₂) :=
theorem mem_map_submodule (e : L →ₗ⁅R⁆ L₂) (x : L₂) :
x ∈ K.map e ↔ x ∈ (K : Submodule R L).map (e : L →ₗ[R] L₂) :=
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser Oct 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a missing lemma here,

    (K.map e : Submodule R L) = (K : Submodule R L).map (e : L →ₗ[R] L₂) :=

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this, I think the name is right

@ericrbg
Copy link
Copy Markdown
Contributor Author

ericrbg commented Nov 16, 2023

I'm not sure how to fix the lemmas in SelfAdjoint, I think they were using some crazy defeq that I don't know. I added some debugging information,

@ericrbg ericrbg added please-adopt Inactive PR (would be valuable to adopt) and removed awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. awaiting-review labels Feb 7, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Mar 8, 2024
@grunweg grunweg added the t-algebra Algebra (groups, rings, fields, etc) label May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) please-adopt Inactive PR (would be valuable to adopt) t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants