perf: improve some instances in MvPolynomial#7436
Closed
ChrisHughes24 wants to merge 3 commits intomasterfrom
Closed
perf: improve some instances in MvPolynomial#7436ChrisHughes24 wants to merge 3 commits intomasterfrom
ChrisHughes24 wants to merge 3 commits intomasterfrom
Conversation
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 10e1279. Benchmark Metric Change
=====================================================================
+ ~Mathlib.Data.MvPolynomial.Funext instructions -6.2%
- ~Mathlib.NumberTheory.LegendreSymbol.GaussSum instructions 6.4%
+ ~Mathlib.RingTheory.FinitePresentation instructions -27.0%
+ ~Mathlib.RingTheory.Jacobson instructions -5.0%
- ~Mathlib.RingTheory.MvPolynomial.Basic instructions 5.8%
+ ~Mathlib.RingTheory.Polynomial.Quotient instructions -13.1%
+ ~Mathlib.RingTheory.WittVector.WittPolynomial instructions -7.3% |
ChrisHughes24
commented
Oct 4, 2023
mattrobball
reviewed
Oct 4, 2023
Contributor
mattrobball
left a comment
There was a problem hiding this comment.
It is tedious but building all the intermediate instances for hierarchy should be best for performance.
| AddMonoidAlgebra.commRing | ||
| --TODO: add reference to library note in PR #7432 | ||
| { AddMonoidAlgebra.commRing with | ||
| toSemiring := MvPolynomial.commSemiring.toSemiring } |
Contributor
There was a problem hiding this comment.
Is there no Ring instance? This seems problematic to unify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.