perf: improve some instances in Submodule#7408
Closed
ChrisHughes24 wants to merge 6 commits intomasterfrom
Closed
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 767f43c. Benchmark Metric Change
============================================================================
- build wall-clock 68.7%
+ ~Mathlib.Algebra.Category.GroupCat.Injective instructions -5.5%
+ ~Mathlib.Algebra.Category.ModuleCat.EpiMono instructions -12.2%
+ ~Mathlib.Algebra.Category.ModuleCat.Images instructions -6.0%
+ ~Mathlib.Algebra.Category.ModuleCat.Subobject instructions -10.4%
+ ~Mathlib.Algebra.Lie.TensorProduct instructions -9.6%
+ ~Mathlib.LinearAlgebra.AffineSpace.FiniteDimensional instructions -14.6%
+ ~Mathlib.LinearAlgebra.AffineSpace.Restrict instructions -20.1%
+ ~Mathlib.LinearAlgebra.Eigenspace.Basic instructions -5.2%
+ ~Mathlib.LinearAlgebra.FiniteDimensional instructions -5.8%
+ ~Mathlib.LinearAlgebra.FreeModule.Finite.Rank instructions -10.4%
+ ~Mathlib.LinearAlgebra.Isomorphisms instructions -39.7%
+ ~Mathlib.RingTheory.Artinian instructions -5.5%
+ ~Mathlib.RingTheory.SimpleModule instructions -36.4% |
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit eacbd41. Benchmark Metric Change
============================================================================
+ ~Mathlib.Algebra.Category.GroupCat.Injective instructions -5.4%
+ ~Mathlib.Algebra.Category.ModuleCat.EpiMono instructions -12.2%
+ ~Mathlib.Algebra.Category.ModuleCat.Images instructions -6.0%
+ ~Mathlib.Algebra.Category.ModuleCat.Subobject instructions -10.4%
+ ~Mathlib.Algebra.Lie.TensorProduct instructions -9.6%
+ ~Mathlib.LinearAlgebra.AffineSpace.FiniteDimensional instructions -14.6%
+ ~Mathlib.LinearAlgebra.AffineSpace.Restrict instructions -20.1%
+ ~Mathlib.LinearAlgebra.Eigenspace.Basic instructions -5.2%
+ ~Mathlib.LinearAlgebra.FiniteDimensional instructions -5.8%
+ ~Mathlib.LinearAlgebra.FreeModule.Finite.Rank instructions -10.3%
+ ~Mathlib.LinearAlgebra.Isomorphisms instructions -39.7%
+ ~Mathlib.RingTheory.Artinian instructions -5.5%
+ ~Mathlib.RingTheory.SimpleModule instructions -36.4% |
Member
|
Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.