Skip to content

feat: support products in the differential geometry elaborators#30421

Closed
grunweg wants to merge 44 commits intoleanprover-community:masterfrom
grunweg:diffgeo-custom-elaborators-products-v2
Closed

feat: support products in the differential geometry elaborators#30421
grunweg wants to merge 44 commits intoleanprover-community:masterfrom
grunweg:diffgeo-custom-elaborators-products-v2

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Oct 10, 2025

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 10, 2025

PR summary 2b4c6152f1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ FindModelResult
+ NormedSpaceInfo
+ findModelInner
+ isCLMReduciblyDefeqCoefficients
+ tryStrategy'
- findModel

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg force-pushed the diffgeo-custom-elaborators-products-v2 branch from 05aa587 to 021e378 Compare October 10, 2025 22:31
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 10, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Oct 12, 2025

#30463 implements a baby version, which just supports binary products (and errors on products of normed spaces).

@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 14, 2025
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Oct 28, 2025
grunweg and others added 13 commits January 16, 2026 22:27
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
These are not exhaustive, but probably a good start.
…ct space,

return that space and its base field

A future commit will use this to warn on the product of two models with corners
on normed spaces (as there are two potential models on it, which are not
definitionally equal).
The inner loop handles finding a model on a non-product, and the
outer loop will just be responsible for products, disjoint unions
and open subsets of a manifold.
And update diagnostics for slight error message tweaks (for the better).
This makes the code clearer (and also makes it easier to change which
information we store): reverting to e.g. just a Boolean is easier now.
@grunweg grunweg force-pushed the diffgeo-custom-elaborators-products-v2 branch from c5ee13b to d23518b Compare January 24, 2026 21:34
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 24, 2026
@tb65536 tb65536 added the t-differential-geometry Manifolds etc label Jan 28, 2026
@tb65536 tb65536 removed their assignment Jan 28, 2026
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jan 28, 2026
@mathlib4-merge-conflict-bot
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@joneugster joneugster added the WIP Work in progress label Feb 1, 2026
@joneugster joneugster changed the title WIP: support products in the differential geometry elaborators feat: support products in the differential geometry elaborators Feb 1, 2026
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 2, 2026
@mathlib-dependent-issues mathlib-dependent-issues bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 23, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Mar 1, 2026

All merged now; closing.

@grunweg grunweg closed this Mar 1, 2026
@grunweg grunweg deleted the diffgeo-custom-elaborators-products-v2 branch March 1, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-differential-geometry Manifolds etc WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants