feat: support products in the differential geometry elaborators#30421
Closed
grunweg wants to merge 44 commits intoleanprover-community:masterfrom
Closed
feat: support products in the differential geometry elaborators#30421grunweg wants to merge 44 commits intoleanprover-community:masterfrom
grunweg wants to merge 44 commits intoleanprover-community:masterfrom
Conversation
PR summary 2b4c6152f1Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
05aa587 to
021e378
Compare
3 tasks
Contributor
Author
|
#30463 implements a baby version, which just supports binary products (and errors on products of normed spaces). |
26 tasks
Collaborator
|
This pull request has conflicts, please merge |
This function needs a better name!
Update tests (and add a new one): so progress, but not good enough. The mathematical tests also need fixing first.
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
These are not exhaustive, but probably a good start.
…ct space, return that space and its base field A future commit will use this to warn on the product of two models with corners on normed spaces (as there are two potential models on it, which are not definitionally equal).
The inner loop handles finding a model on a non-product, and the outer loop will just be responsible for products, disjoint unions and open subsets of a manifold.
And update diagnostics for slight error message tweaks (for the better).
This makes the code clearer (and also makes it easier to change which information we store): reverting to e.g. just a Boolean is easier now.
c5ee13b to
d23518b
Compare
Collaborator
|
This pull request has conflicts, please merge |
Contributor
Author
|
All merged now; closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing to see yet. Best reviewed commit by commit.