Skip to content

Funpropfix mr#27806

Merged
fpvandoorn merged 386 commits intoleanprover-community:funpropfixfrom
grunweg:funpropfix-mr
Aug 1, 2025
Merged

Funpropfix mr#27806
fpvandoorn merged 386 commits intoleanprover-community:funpropfixfrom
grunweg:funpropfix-mr

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Aug 1, 2025

Pushing #25254 to completion.


Open in Gitpod

ScottCarnahan and others added 30 commits July 23, 2025 21:12
…o separate file (leanprover-community#27337)

This PR moves material that uses `MonoidWithZero` into a separate file.
…nity#27285)

`dist_pos` is already a simp lemma, so `dist_nonneg` should be too.
This PR adds a defeq test for multiple paths that convert rings in Mathlib's algebraic hierarchy to abelian groups in grind's hierarchy.
This defeq test used to fail before `leanprover/lean4:v4.22.0-rc3`.
…ommunity#26169)

In order to construct a model category, we may sometimes have basically proven all the axioms with the exception of the left lifting property of cofibrations with respect to trivial fibrations. A trick by Joyal allows to obtain this lifting property under suitable assumptions, namely that cofibrations are stable under composition and cobase change. (The dual statement is also formalized.)

This will be used in the formalization of the model category structure on topological spaces, simplicial sets, simplicial presheaves, etc.



Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
…ity#23547)

Let `P` and `P'` be morphism properties of schemes. We show some results to deduce
that `P` descends along `P'` from a codescent property of ring homomorphisms.



Co-authored-by: Christian Merten <136261474+chrisflav@users.noreply.github.com>
…7396)

This PR deals with adaptation notes in Mathlib that have become irrelevant or easily fixable. The remainder are going to require actual thinking to fix.
…ences (leanprover-community#25943)

Given a commutative ring `k` and a group `G`, this PR shows that a short exact sequence of `k`-linear `G`-representations 
`0 ⟶ X₁ ⟶ X₂ ⟶ X₃ ⟶ 0` induces a short exact sequence of complexes
`0 ⟶ inhomogeneousChains X₁ ⟶ inhomogeneousChains X₂ ⟶ inhomogeneousChains X₃ ⟶ 0`.

Since the homology of `inhomogeneousChains Xᵢ` is the group homology of `Xᵢ`, this allows us to specialize API about long exact sequences to group homology.



Co-authored-by: 101damnations <101damnations@github.com>
We now have a `Defs` file defining `SignType` and basic instances, as well as a `Basic` file proving results about the sign function on a ring.

The files have not been changed beyond updating the module description.
…ut `mkPiAlgebra` (leanprover-community#27352)

Also swap the order of some lemmas to put the ones with weaker typeclass assumptions first.
…clarations (leanprover-community#27389)

These were introduced mostly as an adaptation for lean4#7717, but they seem to be unnecessary anymore. Since the changes were applied long ago, I can't see the build errors in the logs to figure out the exact issue. (I assume that they simply were not getting inferred.)

In addition to the now-unnecessary `norm_mul_self_le` field for `CStarAlgebra` introduced in those adaptation notes, we can also get rid of quite a few unnecessary `mul_comm` fields.
…anprover-community#27421)

As discussed [here](https://leanprover.zulipchat.com/#narrow/channel/113489-new-members/topic/.E2.9C.94.20Maximum.20recursion.20error.20at.20simp.20tactic/with/530502013), I got an infinite simp loop where it repeatedly tried to apply `PullbackCone.π_app_left`. This was the definition from mathlib:

```
/-- The first projection of a pullback cone. -/
abbrev fst (t : PullbackCone f g) : t.pt ⟶ X :=
  t.π.app WalkingCospan.left
...
@[simp]
theorem π_app_left (c : PullbackCone f g) : c.π.app WalkingCospan.left = c.fst := rfl
```

Seems like it unfolded the abbrev to immedeately apply the theorem again. So I removed the simp tags, let's see if the build runs through.
…ty#26626)

Currently, `CompleteLattice` extends `Top` and `Bot`, and introduces `le_top` and `bot_le`. Finally, `CompleteLattice` introduces an instance of `BoundedOrder`. This PR makes `CompleteLattice` extend `BoundedOrder` directly instead.
…rover-community#26114)

This is part of leanprover-community#25140, and is the special case of Hahn embedding theorem applied to archimedean group.
Adds a `@[simp]` theorem `lift_symm_apply` and a regular theorem `coe_lift_symm`.
)

Fix the module docstring to reflect the actual names of the dsimprocs
Add lemmas about `sub`/`neg` for `aeval`. These are already available for `eval` and `eval₂`.
… note "we should have a tactic to crush this" (leanprover-community#27372)

Remove:

```
  /- The below proof (due to Mario Carneiro, Johan Commelin, Bhavik Mehta, Jingting Wang) should
     not really be necessary: we should have a tactic to crush this. -/
```

We now have such a tactic! 🎉
…chimedean (leanprover-community#27436)

Thanks to the ongoing effort to get the Hahn Embedding theorem into Mathlib
…community#27360)

Adds lemmas for rdropWhile and rtakeWhile.

These lemmas were identified while doing work for Project Numina.




Co-authored-by: Bolton Bailey <bolton.bailey@gmail.com>
…ver-community#27405)

This bug in the `reorder` feature was found while developing `to_dual`. To fix it, we modify the `expand` function to not just eta-expand, but also to expand raw projections.
…orders are trivial (leanprover-community#27172)

Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
…community#27338)

The usual `smul_eq_mul` simp lemma runs into a diamond from two `SMul` instances on units of a `CommMonoid`: `Units.mulAction'.toSMul` and `Mul.toSMul`. This PR adds an extra simp lemma to cover this case.
euprunin and others added 14 commits August 1, 2025 03:26
One should instead use `(Module.Free.chooseBasis R M).repr`.
@grunweg grunweg added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. and removed WIP Work in progress labels Aug 1, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 1, 2025

PR summary c1b416635a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Finset.aemeasurable_fun_prod
+ Finset.aemeasurable_sum'
+ Finset.measurable_fun_prod
+ Finset.measurable_prod_apply
+ Finset.measurable_sum'
+ Finset.stronglyMeasurable_prod_apply
+ List.aemeasurable_fun_prod
+ List.aemeasurable_sum'
+ List.measurable_fun_prod
+ List.measurable_sum'
+ Multiset.aemeasurable_fun_prod
+ Multiset.aemeasurable_sum'
+ Multiset.measurable_fun_prod
+ Multiset.measurable_sum'
+ _root_.Finset.aestronglyMeasurable_fun_prod
+ _root_.Finset.aestronglyMeasurable_sum'
+ _root_.Finset.stronglyMeasurable_fun_prod
+ _root_.Finset.stronglyMeasurable_sum'
+ _root_.List.aestronglyMeasurable_fun_prod
+ _root_.List.aestronglyMeasurable_sum'
+ _root_.List.stronglyMeasurable_fun_prod
+ _root_.List.stronglyMeasurable_sum'
+ _root_.Multiset.aestronglyMeasurable_fun_prod
+ _root_.Multiset.aestronglyMeasurable_sum'
+ _root_.Multiset.stronglyMeasurable_fun_prod
+ _root_.Multiset.stronglyMeasurable_sum'
+ measurable_fun_sum
+++ measurable_fun_prod
- measurable_sum
--- measurable_prod

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 1, 2025
@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 1, 2025
@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Aug 1, 2025
@fpvandoorn
Copy link
Copy Markdown
Member

fpvandoorn commented Aug 1, 2025

Thanks for finishing this!
How about we merge this into leanprover-community:funpropfix and then merge that into master? Then we keep easier access to all the review comments. Can you change the base branch?

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Aug 1, 2025

That sounds good --- how can I change the base branch from github's UI? (I can open a new PR, say in 5 minutes from the office.)

@grunweg grunweg changed the base branch from master to funpropfix August 1, 2025 10:49
@fpvandoorn fpvandoorn merged commit 6b17478 into leanprover-community:funpropfix Aug 1, 2025
10 checks passed
@grunweg grunweg deleted the funpropfix-mr branch August 1, 2025 10:50
@fpvandoorn
Copy link
Copy Markdown
Member

Oops, my bad. Changing the base branch messed up the commit history, because this branch merged Mathlib master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.