Skip to content

feat: add an ext lemma for the opposite category#25914

Open
eric-wieser wants to merge 5 commits intomasterfrom
eric-wieser/aesop-cat
Open

feat: add an ext lemma for the opposite category#25914
eric-wieser wants to merge 5 commits intomasterfrom
eric-wieser/aesop-cat

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

This powers up aesop_cat.


Open in Gitpod

@eric-wieser eric-wieser added the t-category-theory Category theory label Jun 15, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 15, 2025

PR summary 0e9bcbf7a1

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Hom.unop_ext

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@robin-carlier
Copy link
Copy Markdown
Contributor

Can you fix the build? I’ve had success with a similiar lemma (for monoidal opposite instead of "regular" opposite) in #25860, and I’m pretty sure this would ease automation in #25861.

@robin-carlier robin-carlier added awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Jun 17, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 5, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@robin-carlier
Copy link
Copy Markdown
Contributor

@eric-wieser do you intend to continue the work in this PR?

@eric-wieser
Copy link
Copy Markdown
Member Author

It's pretty low priority for me, feel free to create a new PR you can push to and I'll close this one

@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented Jul 31, 2025

I just came here from issue triage. @robin-carlier Would you like to take on this PR? Thanks for asking about it, in any case.

@robin-carlier
Copy link
Copy Markdown
Contributor

@grunweg Yes, I intend to turn it into something at some point, but it will have to wait a few days for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-category-theory Category theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants