feat(LinearAlgebra): add independent iSup to LinearPMap#25348
Closed
feat(LinearAlgebra): add independent iSup to LinearPMap#25348
Conversation
PR summary 99ad85425bImport changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.LinearAlgebra.LinearPMap | 807 | 977 | +170 (+21.07%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Group.UniqueProds.VectorSpace |
9 |
45 filesMathlib.Analysis.Calculus.TangentCone Mathlib.Analysis.Convex.Birkhoff Mathlib.Analysis.Convex.Caratheodory Mathlib.Analysis.Convex.Combination Mathlib.Analysis.Convex.Cone.Extension Mathlib.Analysis.Convex.Independent Mathlib.Analysis.Convex.Jensen Mathlib.Analysis.Convex.PartitionOfUnity Mathlib.Analysis.Convex.SimplicialComplex.Basic Mathlib.Analysis.Convex.StoneSeparation Mathlib.Analysis.Convex.StrictConvexSpace Mathlib.Analysis.Convex.Topology Mathlib.Analysis.Convex.TotallyBounded Mathlib.Analysis.Convex.Uniform Mathlib.Analysis.LocallyConvex.AbsConvex Mathlib.Analysis.LocallyConvex.Barrelled Mathlib.Analysis.LocallyConvex.Bounded Mathlib.Analysis.LocallyConvex.WeakDual Mathlib.Analysis.LocallyConvex.WithSeminorms Mathlib.Analysis.Normed.Affine.Simplex Mathlib.Analysis.Normed.Group.AddCircle Mathlib.Analysis.Normed.Module.Convex Mathlib.Analysis.Normed.Module.Ray Mathlib.Analysis.NormedSpace.BallAction Mathlib.Analysis.NormedSpace.ENormedSpace Mathlib.Analysis.NormedSpace.Extr Mathlib.Analysis.NormedSpace.HomeomorphBall Mathlib.Analysis.NormedSpace.Pointwise Mathlib.Analysis.NormedSpace.Real Mathlib.Analysis.NormedSpace.RieszLemma Mathlib.Analysis.NormedSpace.SphereNormEquiv Mathlib.GroupTheory.CosetCover Mathlib.LinearAlgebra.AffineSpace.Basis Mathlib.LinearAlgebra.AffineSpace.Independent Mathlib.LinearAlgebra.Basis.VectorSpace Mathlib.Topology.Algebra.Module.Cardinality Mathlib.Topology.Algebra.Module.LocallyConvex Mathlib.Topology.Algebra.Module.Multilinear.Bounded Mathlib.Topology.Algebra.Module.UniformConvergence Mathlib.Topology.CWComplex.Classical.Basic Mathlib.Topology.CWComplex.Classical.Finite Mathlib.Topology.Category.DeltaGenerated Mathlib.Topology.Compactness.DeltaGeneratedSpace Mathlib.Topology.ContinuousMap.LocallyConvex Mathlib.Topology.MetricSpace.PartitionOfUnity |
10 |
Mathlib.Algebra.Category.Grp.LargeColimits Mathlib.Algebra.Category.Grp.Ulift |
21 |
3 filesMathlib.Algebra.Category.Grp.EnoughInjectives Mathlib.Algebra.Category.Grp.Injective Mathlib.Algebra.Module.CharacterModule |
26 |
Mathlib.Topology.Algebra.Module.LinearPMap |
34 |
Mathlib.Algebra.Category.ModuleCat.Injective |
90 |
Mathlib.Algebra.Module.Injective |
158 |
Mathlib.LinearAlgebra.LinearPMap |
170 |
Declarations diff
+ DFinsupp.linearEquiv_val_apply
+ DFinsupp.lsumEquiv
+ DFinsupp.lsumMap_injective
+ DFinsupp.lsumMap_surjective
+ DFinsupp.lsumMap_val_apply
+ domain_indepiSup
+ indepiSup
+ indepiSup_apply
+ indepiSup_apply_single
+ le_indepiSup
+ lsumMap
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
eric-wieser
reviewed
Jun 8, 2025
|
|
||
| /-- `DFinsupp.lsum` as a linear map to iSup of submodules, | ||
| whose surjectivity is implied by `Submodule.mem_iSup_iff_exists_dfinsupp`. -/ | ||
| def lsumMap (p : ι → Submodule R N) : |
Member
There was a problem hiding this comment.
This is very closely related to DirectSum.range_coeLinearMap (via LinearMap.codRestrict); I'll try to get back to this with a concrete suggetion within the next few days, if another reivewer doesn't beat me to it.
Collaborator
Author
There was a problem hiding this comment.
@eric-wieser Have you got more suggestions? I almost forgot this myself...
Collaborator
Author
|
Closing as I have found a better way utilizing DirectSum |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #25140. To obtain the Hahn embedding, we need to construct an partial linear map spanned by a family of submodules as the base case. This PR prepares for it.