Skip to content

chore(Topology/Instances/ENNReal): rename Defs to Basic.lean#22094

Closed
grunweg wants to merge 1 commit intomasterfrom
MR-ennreal-instances-renamedefs
Closed

chore(Topology/Instances/ENNReal): rename Defs to Basic.lean#22094
grunweg wants to merge 1 commit intomasterfrom
MR-ennreal-instances-renamedefs

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Feb 19, 2025

To make room for a leaner file Defs.lean in #22093.


Imho, merging this only makes sense if #22093 is worth it.

Open in Gitpod

@grunweg grunweg added WIP Work in progress awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. labels Feb 19, 2025
@grunweg grunweg requested a review from YaelDillies February 19, 2025 17:19
@github-actions
Copy link
Copy Markdown

PR summary b96a6749a4

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Topology.Instances.ENNReal.Defs -1120
Mathlib.Topology.Instances.ENNReal.Basic 1120

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Feb 19, 2025
@grunweg grunweg removed the WIP Work in progress label Feb 19, 2025
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Feb 20, 2025

Closing this PR, as #22093 will not land in its current form.

@grunweg grunweg closed this Feb 20, 2025
@YaelDillies YaelDillies deleted the MR-ennreal-instances-renamedefs branch August 15, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant