joke: make JacobiZariski universe-monomorphic#21165
Closed
Conversation
PR summary 7c4c5a6db3Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Member
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 7c4c5a6. Benchmark Metric Change
=================================================================
+ ~Mathlib.RingTheory.Kaehler.JacobiZariski instructions -60.7% |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file, the slowest in mathlib, is only imported by
RingTheory.Etale.Kaehler, which is already universe monomorphic, so this change shouldn't break anything.This PR shouldn't be merged; I only made it because I am interested in measuring how much this speeds things up compared to #21129 (for which the speedcenter reported a 29% decrease in instructions).