Skip to content

Mc products refactor#20997

Merged
maddycrim merged 4 commits intoMC_productsfrom
MC_products_refactor
Jan 23, 2025
Merged

Mc products refactor#20997
maddycrim merged 4 commits intoMC_productsfrom
MC_products_refactor

Conversation

@maddycrim
Copy link
Copy Markdown
Collaborator


Open in Gitpod

@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jan 23, 2025
@maddycrim maddycrim merged commit 27be9a7 into MC_products Jan 23, 2025
@mathlib-bors mathlib-bors bot deleted the MC_products_refactor branch January 23, 2025 18:36
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 23, 2025
@github-actions
Copy link
Copy Markdown

PR summary 3126fc222e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.Localization.Pi (new file) 828

Declarations diff

+ bijective_lift_piRingHom_algebraMap_comp_piEvalRingHom
+ iff_map_piEvalRingHom
+ iff_of_le_of_exists_dvd
+ instance (M : Π i, Submonoid (R i)) [∀ i, IsLocalization (M i) (S i)] :
+ instance (g : I → Type*) [∀ i, CommSemiring (f i)] [∀ i, Semiring (g i)]
+ isUnit_iff
+ isUnit_piRingHom_algebraMap_comp_piEvalRingHom
+ units

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants