Skip to content

fix(1000.yaml): remove wrong field 'note'#20555

Closed
grunweg wants to merge 1 commit intomasterfrom
MR-1000-fix-comment
Closed

fix(1000.yaml): remove wrong field 'note'#20555
grunweg wants to merge 1 commit intomasterfrom
MR-1000-fix-comment

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 7, 2025

This should be called comment instead. Once leanprover-community/leanprover-community.github.io#563 lands, it can be called so.


Open in Gitpod

This should be called comment instead.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 7, 2025

PR summary 1eb0459c25

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@bryangingechen
Copy link
Copy Markdown
Contributor

I propose we close this and just proceed with #20078 per leanprover-community/leanprover-community.github.io#563 (comment) (otherwise we're just making additional work for ourselves).

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 7, 2025

Sure, that also works for me.

@grunweg grunweg closed this Jan 7, 2025
@grunweg grunweg deleted the MR-1000-fix-comment branch January 7, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants