Skip to content

Work on lemma 'Polynomial.flt_catalan_deriv'#19018

Merged
seewoo5 merged 6 commits intofeature/poly-fltfrom
feature/poly-flt-deriv
Nov 14, 2024
Merged

Work on lemma 'Polynomial.flt_catalan_deriv'#19018
seewoo5 merged 6 commits intofeature/poly-fltfrom
feature/poly-flt-deriv

Conversation

@jcpaik
Copy link
Copy Markdown
Collaborator

@jcpaik jcpaik commented Nov 14, 2024 •
edited
Loading

Makes a partial progress towards #18882

Open in Gitpod

@jcpaik jcpaik requested a review from seewoo5 November 14, 2024 05:51
@github-actions github-actions bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Nov 14, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 14, 2024 •
edited
Loading

PR summary 626b843fb2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.NumberTheory.FLT.Polynomial 1179

Declarations diff

+ Polynomial.flt'
+ Polynomial.flt_catalan
+ Polynomial.flt_catalan_aux
+ fermatLastTheoremPolynomial
+ radical_isUnit_eq
+ radical_isUnit_mul_left
+ radical_isUnit_mul_right
- radical_mul_unit
- radical_unit_eq_one
- radical_unit_mul

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

jcpaik and others added 2 commits November 14, 2024 14:53
@jcpaik @github-actions
lint
48b3f87 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jcpaik @github-actions
lint
626b843 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jcpaik jcpaik added WIP Work in progress and removed new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! labels Nov 14, 2024
@seewoo5
Copy link
Copy Markdown
Collaborator

seewoo5 commented Nov 14, 2024

This supposed to be merged first then #19037 right? Also there are some lint errors, I can fix this if you want

@jcpaik
Copy link
Copy Markdown
Collaborator Author

jcpaik commented Nov 14, 2024

Yes, and I think lint errors are best fixed in the main PR branch

@seewoo5 seewoo5 merged commit 0a00767 into feature/poly-flt Nov 14, 2024
@mathlib-bors mathlib-bors bot deleted the feature/poly-flt-deriv branch November 14, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seewoo5 seewoo5 Awaiting requested review from seewoo5

Assignees

No one assigned

Labels

WIP Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jcpaik @seewoo5