chore: remove CoeFun instances where FunLike is available#17921
Closed
Vierkantor wants to merge 2 commits intomasterfrom
Closed
chore: remove CoeFun instances where FunLike is available#17921Vierkantor wants to merge 2 commits intomasterfrom
Vierkantor wants to merge 2 commits intomasterfrom
Conversation
Contributor
Author
|
!bench |
PR summary acdbe3f73aImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Collaborator
|
Here are the benchmark results for commit 7254b21. Benchmark Metric Change
===================================================================
- ~Mathlib.Analysis.InnerProductSpace.Adjoint instructions 8.5% |
a142021 to
7339c6f
Compare
Collaborator
|
This PR/issue depends on: |
7339c6f to
8aa42b2
Compare
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 8aa42b2. Benchmark Metric Change
===================================================================
- ~Mathlib.Analysis.InnerProductSpace.Adjoint instructions 8.3% |
Contributor
Author
|
Huh! My suspicion was on |
During the port we found that `FunLike` is robust enough not to need an extra `CoeFun` shortcut. Let's see if that rule can be consistently applied to the whole of the library. There is still duplication between `FunLike` and `CoeFun` for `Grp`, `Mon`, `CommGrp` and `CommMon`, which will need a more thorough fix. See also #17866. Compared to previous tests, this only preserves the `Finsupp` and `DFinsupp` instances; my guess is that they are the important shortcut instances preventing slowdowns.
8aa42b2 to
acdbe3f
Compare
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit acdbe3f. |
Contributor
Author
|
Okay then! Looks like we got the culprit: instance instCoeFun : CoeFun (E ≃ₛₗᵢ[σ₁₂] E₂) fun _ ↦ E → E₂ := ⟨DFunLike.coe⟩Not sure why this is particularly slow to apply... But that's to figure out for later. I'll get the main PR ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the port we found that
FunLikeis robust enough not to need an extraCoeFunshortcut. Let's see if that rule can be consistently applied to the whole of the library.There is still duplication between
FunLikeandCoeFunforGrp,Mon,CommGrpandCommMon, which will need a more thorough fix. See also #17866.I am currently bisecting #17870 to figure out exactly why the benchmarks are indicating a slowdown with no obvious cause.
CoeFuninstances whereFunLikeis available #17917