Skip to content

feat: lint on declarations mentioning Invertible or Unique#17518

Closed
grunweg wants to merge 279 commits intomasterfrom
YK-lint-invertible-unique
Closed

feat: lint on declarations mentioning Invertible or Unique#17518
grunweg wants to merge 279 commits intomasterfrom
YK-lint-invertible-unique

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Oct 7, 2024

Using the same infrastructure as for #10235. Depends on that PR to land first, and also (for the first lint) a zulip discussion if that change is desired/about the best way to enact it.


@grunweg grunweg added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-linter Linter awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there labels Oct 7, 2024
@mergify
Copy link
Copy Markdown

mergify bot commented Oct 7, 2024

⚠️ The sha of the head commit of this PR conflicts with #10235. Mergify cannot evaluate rules on this PR. ⚠️

@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 14, 2024

PR summary ff0f56f577

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
There are 4658 files with changed transitive imports taking up over 193758 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

+ checkUnusedAssumptionInType
+ decidableClassical
+ encodableDenumerable
+ finiteFintype
+ inhabitedNonempty
+ invertibleIsUnit
+ uniqueNonemptySubsingleton

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 14, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Nov 2, 2024
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Feb 15, 2026

Closing in favour of #35340.

@grunweg grunweg closed this Feb 15, 2026
@grunweg grunweg deleted the YK-lint-invertible-unique branch February 15, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-zulip There is a Zulip discussion; the author should await and report/implement the decision reached there blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-linter Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants