Conversation
PR summary 34451f3c7eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
PhoenixIra
reviewed
Oct 8, 2024
Collaborator
PhoenixIra
left a comment
There was a problem hiding this comment.
I left some small suggestions for further golfing.
| apply And.intro (le_lfpApprox f x) | ||
| use le_lfpApprox f x a | ||
| intro a' ha'b | ||
| by_cases haa : a' < a |
Collaborator
There was a problem hiding this comment.
We could also use cases lt_or_le a' a here instead.
| theorem lfpApprox_mono_mid (f : α →o α) : Monotone (lfpApprox f) := by | ||
| intro x₁ x₂ h a | ||
| induction a using Ordinal.induction with | ||
| | h i ih => |
Collaborator
There was a problem hiding this comment.
Maybe you could also get rid of the constructor here and use use le_sup_of_le_left h instead.
| rw [mem_fixedPoints_iff] at h | ||
| induction b using Ordinal.induction with | h b IH => | ||
| apply le_antisymm | ||
| · conv => left; rw [lfpApprox] |
Collaborator
There was a problem hiding this comment.
Suggested change
| · conv => left; rw [lfpApprox] | |
| · rw [lfpApprox] |
This should work as well
Comment on lines
75
to
76
| refine sSup_le_sSup ?h | ||
| apply sup_le_sup_right |
Collaborator
There was a problem hiding this comment.
Suggested change
| refine sSup_le_sSup ?h | |
| apply sup_le_sup_right | |
| apply sSup_le_sSup <| sup_le_sup_right ?h _ |
Or at least we can remove the ?h here, I think.
YaelDillies
reviewed
Nov 2, 2024
Contributor
YaelDillies
left a comment
There was a problem hiding this comment.
I have strain injuries to both wrists, hence must not type much. Please apologise the poor spelling, vague indications and general conciseness.
| theorem lfpApprox_monotone (f : α →o α) (x : α) : Monotone (lfpApprox f x) := by | ||
| intros a b h | ||
| rw [lfpApprox, lfpApprox] | ||
| refine sSup_le_sSup ?h |
| decreasing_by exact h | ||
|
|
||
| theorem lfpApprox_monotone : Monotone (lfpApprox f x) := by | ||
| theorem lfpApprox_monotone (f : α →o α) (x : α) : Monotone (lfpApprox f x) := by |
| exact ⟨a', h'.trans_le h, rfl⟩ | ||
|
|
||
| theorem le_lfpApprox {a : Ordinal} : x ≤ lfpApprox f x a := by | ||
| theorem le_lfpApprox (f : α →o α) (x : α) (a : Ordinal) : x ≤ lfpApprox f x a := by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We avoid making
f : α →o αandx : αexplicit arguments when not needed. We then golf most theorems in the file.