Skip to content

chore: adaptations for nightly-2024-07-18#14888

Closed
kim-em wants to merge 5 commits intobump/v4.11.0from
bump/nightly-2024-07-18
Closed

chore: adaptations for nightly-2024-07-18#14888
kim-em wants to merge 5 commits intobump/v4.11.0from
bump/nightly-2024-07-18

Conversation

@kim-em
Copy link
Copy Markdown
Contributor

@kim-em kim-em commented Jul 19, 2024

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 19, 2024

PR summary 0e4a3dc5dc

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.CategoryTheory.Category.Basic 252 250 -2 (-0.79%)
Mathlib.Algebra.Module.Equiv.Defs 394 392 -2 (-0.51%)
Mathlib.Testing.SlimCheck.Testable 414 412 -2 (-0.48%)
Mathlib.Tactic.Abel 346 345 -1 (-0.29%)
Mathlib.Computability.TuringMachine 448 447 -1 (-0.22%)
Mathlib.MeasureTheory.Constructions.Pi 1228 1227 -1 (-0.08%)
Mathlib.RingTheory.ClassGroup 1228 1227 -1 (-0.08%)
Mathlib.MeasureTheory.Function.SimpleFuncDenseLp 1619 1618 -1 (-0.06%)
Import changes for all files
Files Import difference
Too many changes (4284)!

Declarations diff

+ ext_iff'
+ instance : (forget V G).Faithful where map_injective w := Hom.ext w
+ instance [DecidableEq α] : DecidableEq αˣ := fun _ _ => decidable_of_iff' _ Units.ext_iff
+ mem_getLast?_append_of_mem_getLast?
+ mem_head?_append_of_mem_head?
- AddContent.ext_iff
- exists_eq_right'
- get!_none
- get!_some
- getLast?_append
- head?_append
- head_replicate
- instance : (forget V G).Faithful where map_injective w := Hom.ext _ _ w
- instance [DecidableEq α] : DecidableEq αˣ := fun _ _ => decidable_of_iff' _ ext_iff
- isSome_map
- takeWhile_cons_of_neg
- takeWhile_cons_of_pos
-+-+ Hom.ext'
------------------------------- ext_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 19, 2024

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jul 19, 2024
@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 20, 2024
kim-em and others added 2 commits July 23, 2024 05:29
Co-authored-by: Johan Commelin <johan@commelin.net>
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jul 22, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 22, 2024

👎 Rejected by label

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 22, 2024
@kim-em kim-em removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 22, 2024
@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jul 22, 2024

bors merge

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Jul 22, 2024

Canceled.

@kim-em
Copy link
Copy Markdown
Contributor Author

kim-em commented Jul 22, 2024

Ugh, let's just abandoned, it has been superseded by #14942 and bump/v4.11.0 has already had master merged.

It's not ideal, as we get a less granular history of updates for adaptations, but not terrible.

@kim-em kim-em closed this Jul 22, 2024
@kim-em kim-em deleted the bump/nightly-2024-07-18 branch July 28, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants