Skip to content

refactor: change CliffordAlgebra.lift to use quadratic maps#14720

Draft
eric-wieser wants to merge 10 commits intomasterfrom
eric-wieser/clifford-QuadraticMap
Draft

refactor: change CliffordAlgebra.lift to use quadratic maps#14720
eric-wieser wants to merge 10 commits intomasterfrom
eric-wieser/clifford-QuadraticMap

Conversation

@eric-wieser
Copy link
Copy Markdown
Member

@eric-wieser eric-wieser commented Jul 13, 2024

This works towards addressing a footnote on page 152 of my thesis.

Open in Gitpod

@eric-wieser eric-wieser added WIP Work in progress t-algebra Algebra (groups, rings, fields, etc) labels Jul 13, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 13, 2024 •
edited
Loading

PR summary 61426a8b5b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.QuadraticMap.Isometry.tmul
+ _root_.QuadraticMap.Isometry.tmul_apply
+ comp_toLinearMap_eq
+ instance : Zero ((0 : QuadraticMap R M₁ N) →qᵢ Q₂)
+ ofCompEq
- instance : Zero ((0 : QuadraticForm R M₁) →qᵢ Q₂)
- tmul
- tmul_apply
-+-+ refl

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@ghost ghost added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 17, 2024
@seewoo5 seewoo5 mentioned this pull request Aug 11, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-algebra Algebra (groups, rings, fields, etc) WIP Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eric-wieser