chore: use new HashMap in allNamesByModule#14523
Merged
adomani merged 1 commit intonightly-testingfrom Jul 8, 2024
Merged
Conversation
PR summary 060c2d88bdImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Contributor
Author
|
@adomani the declarations diff appears to be incorrect, here. Do we need to disable this for PRs to something other than |
Contributor
|
The script already takes an optional commit that defaults to master. I would have to look into how to make the action detect the target branch and the script can run with that instead of master, I suppose. I won't have time to look at it today, though, as I'm about to have dinner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note this is a PR to
nightly-testing, since this isn't available onmasteryet, but I think it can be reviewed normally.