Closed
Conversation
PR summary e9dc166942Import changesDependency changes
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
Contributor
|
Let me cross-reference #13977 which tries the same. (I'll be happy to review either, but submitting my PhD thesis takes priority -> I may take about a week to get to this.) |
Contributor
|
@adomani, a clearly inaccurate declaration diff here! |
Contributor
|
I think that the output that you are seeing comes from this: so, not ideal, but also not worrisome! It could probably be fixed by adding an extra space after See here and a couple of lines below. |
Contributor
|
I confirm: if you change awk -v regex="^[+-]${begs}" 'BEGIN{ paired=0; added=0; removed=0 }to awk -v regex="^[+-]${begs} " 'BEGIN{ paired=0; added=0; removed=0 }in no_lost_declarations, then here it reports no change. |
Contributor
|
@adomani please tell me when you open a PR to fix the regex! 🙏 |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
As [reported](#14048 (comment)) and [requested](#14048 (comment)) by Yael! I think that this change is an improvement, but I would be happier if there was a consensus that the `def`, `theorem`, `structure`,... keywords are followed by a space and not a line break before their identifier.
kbuzzard
pushed a commit
that referenced
this pull request
Jun 26, 2024
As [reported](#14048 (comment)) and [requested](#14048 (comment)) by Yael! I think that this change is an improvement, but I would be happier if there was a consensus that the `def`, `theorem`, `structure`,... keywords are followed by a space and not a line break before their identifier.
dagurtomas
pushed a commit
that referenced
this pull request
Jul 2, 2024
As [reported](#14048 (comment)) and [requested](#14048 (comment)) by Yael! I think that this change is an improvement, but I would be happier if there was a consensus that the `def`, `theorem`, `structure`,... keywords are followed by a space and not a line break before their identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.