Skip to content

chore: replace continuity -> fun_prop in remaining directories#14009

Closed
grunweg wants to merge 2 commits intomasterfrom
MR-funprop-misc
Closed

chore: replace continuity -> fun_prop in remaining directories#14009
grunweg wants to merge 2 commits intomasterfrom
MR-funprop-misc

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jun 20, 2024

After the current set of PRs, the only continuity remnants either need more attention or are merely for tagging continuity lemmas.


Open in Gitpod

@grunweg grunweg added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 20, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 20, 2024

PR summary 5f658b14e2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@j-loreaux
Copy link
Copy Markdown
Contributor

As I've mentioned elsewhere, we shouldn't be making fun_prop a default value until #11092 is merged. I'm adding this as a dependency.

@j-loreaux j-loreaux added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jun 24, 2024
@ghost ghost removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Aug 12, 2024
@ghost
Copy link
Copy Markdown

ghost commented Aug 12, 2024

This PR/issue depends on:

@joneugster joneugster added t-analysis Analysis (normed *, calculus) and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Aug 14, 2024
Comment on lines +129 to +130
continuous_toFun := by continuity
continuous_invFun := by continuity
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these because fun_prop doesn't work? If so, why not?

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes. label Aug 15, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 5, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Aug 25, 2025

Closing in favour of #28928 (which is almost identical).

@grunweg grunweg closed this Aug 25, 2025
@grunweg grunweg deleted the MR-funprop-misc branch August 25, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants