chore: trim a few imports and noshake exceptions#12714
Closed
chore: trim a few imports and noshake exceptions#12714
Conversation
Contributor
grunweg
commented
May 6, 2024
- remove a bogus import labelled as such (it is not necessary any more)
- remove a few now-superfluous exceptions from noshake.json.
- sort imports and remove a transitive import in Data/List/Basic
1 task
Ruben-VandeVelde
approved these changes
May 7, 2024
Contributor
Ruben-VandeVelde
left a comment
There was a problem hiding this comment.
It builds, so it must be good
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
YaelDillies
reviewed
May 7, 2024
| Released under Apache 2.0 license as described in the file LICENSE. | ||
| Authors: Mario Carneiro | ||
| -/ | ||
| import Mathlib.Algebra.Ring.Hom.Defs -- FIXME: This import is bogus |
Contributor
There was a problem hiding this comment.
Note that Algebra.Ring.Hom.Defs is still imported in Data.Fintype.Basic. You're just hiding the problem.
Contributor
|
bors r- |
Contributor
|
Canceled. |
Contributor
Author
|
Let me close this: #12787 contains most of these changes; the bogus import removal is not helpful as it hides a problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.