Closed
Conversation
Member
urkud
commented
May 3, 2024
Member
|
Just noting I tried this long ago in leanprover-community/mathlib3#17769, but probably this can replace it |
Member
Author
|
@eric-wieser What's the order of elements in your definition? Which def do you prefer? |
PR summary 1631dc1575
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Data.List.Perm.Basic | 335 | 310 | -25 (-7.46%) |
| Mathlib.Data.List.InsertIdx | 329 | 306 | -23 (-6.99%) |
| Mathlib.Data.List.Nodup | 330 | 307 | -23 (-6.97%) |
| Mathlib.Data.List.NatAntidiagonal | 331 | 308 | -23 (-6.95%) |
| Mathlib.Data.List.Perm.Lattice | 333 | 310 | -23 (-6.91%) |
| Mathlib.Algebra.BigOperators.Group.List.Basic | 356 | 354 | -2 (-0.56%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Data.List.Perm.Basic |
-25 |
9 filesMathlib.Data.List.AList Mathlib.Data.List.Dedup Mathlib.Data.List.Duplicate Mathlib.Data.List.InsertIdx Mathlib.Data.List.InsertNth Mathlib.Data.List.NatAntidiagonal Mathlib.Data.List.Nodup Mathlib.Data.List.Perm.Lattice Mathlib.Data.List.Sigma |
-23 |
3 filesMathlib.Algebra.BigOperators.Group.List.Basic Mathlib.Algebra.FreeMonoid.Basic Mathlib.Algebra.FreeMonoid.Count |
-2 |
Mathlib.Data.List.OffDiag (new file) |
316 |
Declarations diff
+ Nodup.mem_offDiag
+ Nodup.of_offDiag
+ Nodup.offDiag
+ Perm.offDiag
+ Sublist.flatMap_right
+ count_offDiag_eq_mul_sub_bif
+ length_offDiag
+ length_offDiag'
+ map_fst_zipIdx
+ map_fun_fst_zipIdx
+ mem_offDiag_iff_getElem
+ nodup_offDiag
+ offDiag
+ offDiag_cons_perm
+ offDiag_nil
+ offDiag_singleton
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Use `Nat`-specific lemmas instead of generic ones.
Collaborator
|
This pull request has conflicts, please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.