doc: add @[inherit_doc] to some local notation#11942
Closed
Conversation
grunweg
commented
Apr 6, 2024
1 task
YaelDillies
reviewed
Jun 6, 2024
Comment on lines
+22
to
+23
| /-- Notation for two elements of a monoid are associated, i.e. | ||
| if one of them is another one multiplied by a unit on the right.-/ |
Contributor
There was a problem hiding this comment.
Grammer is wrong here. Maybe
Suggested change
| /-- Notation for two elements of a monoid are associated, i.e. | |
| if one of them is another one multiplied by a unit on the right.-/ | |
| /-- Notation for two elements of a monoid to be associated, i.e. | |
| for one of them to be the other multiplied by a unit on the right. -/ |
or maybe just @[inherit_doc] as you already do in Algebra.Polynomial.Splits?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding is that because these are local notation, @eric-wieser's comment on zulip doesn't apply.