Closed
Conversation
|
This PR/issue depends on:
|
…ommunity/mathlib4 into adomani/hash_command_linter
…er-community/mathlib4 into adomani/hast_command_lint-a-lot
…ommunity/mathlib4 into adomani/hash_command_linter
Contributor
|
#11019 was updated to also add the linter to Tactic.Common --- I presume this PR can be closed now? |
Contributor
Author
|
This PR can be closed. Especially with linters, I sometimes prepare two PRs:
This one is now obsolete. Also, I am happy to use the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a companion to #11019. The main difference is that this PR places the
#-command linter inMathlib.Tactic.Basic, so that it actually lints most ofMathlib.Other than that, the "main" file
Mathlib.Tactic.HashCommandLintershould be identical in the two PRs.#-commands #11019, which simply defines the linter and the test file.