chore: adaptations for nightly-2024-02-01#10154
Merged
kim-em merged 13 commits intobump/v4.6.0from Feb 2, 2024
Merged
Conversation
kbuzzard
approved these changes
Feb 1, 2024
Member
There was a problem hiding this comment.
The diff looks pretty harmless to me (other than the tactic stuff, which I don't understand) but there are a couple of funny set_options and I don't know if this is intentional (edit: it almost certainly isn't; I've just removed them and things work fine)
Contributor
|
Thanks. I looked over the changes last night from #9843 and everything looked good except that. I thought I pushed a fix though. Not intentional. Left over from debugging. |
mattrobball
reviewed
Feb 1, 2024
Contributor
mattrobball
left a comment
There was a problem hiding this comment.
Some unnecessary lines.
mattrobball
approved these changes
Feb 1, 2024
kim-em
commented
Feb 1, 2024
eric-wieser
reviewed
Feb 1, 2024
Comment on lines
-599
to
+603
| -- is not achieved... | ||
| -- is not achieved... Previous attempt was | ||
| -- { @FractionalIdeal.commSemiring A _ A⁰ K _ _, -- Project out the computable fields first. | ||
| -- (by infer_instance : CancelCommMonoidWithZero (FractionalIdeal A⁰ K)) with } | ||
| noncomputable instance FractionalIdeal.cancelCommMonoidWithZero : | ||
| CancelCommMonoidWithZero (FractionalIdeal A⁰ K) := | ||
| { @FractionalIdeal.commSemiring A _ A⁰ K _ _, -- Project out the computable fields first. | ||
| (by infer_instance : CancelCommMonoidWithZero (FractionalIdeal A⁰ K)) with } | ||
| CancelCommMonoidWithZero (FractionalIdeal A⁰ K) := inferInstance |
Member
There was a problem hiding this comment.
#10173 contains a fix for this that works on master and this branch.
eric-wieser
reviewed
Feb 1, 2024
| show Units.map g β⁻¹ / β⁻¹ = Additive.toMul (x.1 g) | ||
| rw [map_inv, div_inv_eq_mul, mul_comm] | ||
| exact mul_inv_eq_iff_eq_mul.2 (hβ g).symm | ||
| apply mul_inv_eq_iff_eq_mul.2 (hβ g).symm |
Contributor
There was a problem hiding this comment.
My guess is transparency
kim-em
commented
Feb 2, 2024
…tly-2024-02-01' of github.com:leanprover-community/mathlib4 into adaptations_nightly-2024-02-01
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the adaptation PR for nightly-2024-02-01.
In rolls in the branches
simptypes andpreandpostmethod semantics leanprover/lean4#3210As these both landed in the same nightly, we're having to do the update in one go.
Note this nightly is intended to become
v4.6.0-rc1tomorrow.