Skip to content

Commit b84002d

Browse files
committed
chore(RingTheory/WittVector/Basic): remove porting notes (#13927)
Remove a couple uncategorised, superfluous porting notes.
1 parent 6f05744 commit b84002d

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

β€ŽMathlib/RingTheory/WittVector/Basic.leanβ€Ž

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ private def ghostFun : π•Ž R β†’ β„• β†’ R := fun x n => aeval x.coeff (W_ β„€
158158
section Tactic
159159
open Lean Elab Tactic
160160

161-
-- porting note: removed mathport output related to meta code.
162161
/-- An auxiliary tactic for proving that `ghostFun` respects the ring operations. -/
163162
elab "ghost_fun_tac" Ο†:term "," fn:term : tactic => do
164163
evalTactic (← `(tactic| (
@@ -219,14 +218,10 @@ private theorem ghostFun_intCast (i : β„€) : ghostFun (i : π•Ž R) = i :=
219218
alias ghostFun_int_cast := ghostFun_intCast
220219

221220
private lemma ghostFun_nsmul (m : β„•) (x : WittVector p R) : ghostFun (m β€’ x) = m β€’ ghostFun x := by
222-
-- porting note: I had to add the explicit type ascription.
223-
-- This could very well be due to my poor tactic writing!
224-
ghost_fun_tac m β€’ (X 0 : MvPolynomial _ β„€), ![x.coeff]
221+
ghost_fun_tac m β€’ (X 0), ![x.coeff]
225222

226223
private lemma ghostFun_zsmul (m : β„€) (x : WittVector p R) : ghostFun (m β€’ x) = m β€’ ghostFun x := by
227-
-- porting note: I had to add the explicit type ascription.
228-
-- This could very well be due to my poor tactic writing!
229-
ghost_fun_tac m β€’ (X 0 : MvPolynomial _ β„€), ![x.coeff]
224+
ghost_fun_tac m β€’ (X 0), ![x.coeff]
230225

231226
private theorem ghostFun_pow (m : β„•) : ghostFun (x ^ m) = ghostFun x ^ m := by
232227
ghost_fun_tac X 0 ^ m, ![x.coeff]
@@ -256,8 +251,6 @@ private def ghostEquiv' [Invertible (p : R)] : π•Ž R ≃ (β„• β†’ R) where
256251

257252
@[local instance]
258253
private def comm_ring_aux₁ : CommRing (π•Ž (MvPolynomial R β„š)) :=
259-
-- Porting note: no longer needed?
260-
-- letI : CommRing (MvPolynomial R β„š) := MvPolynomial.commRing
261254
(ghostEquiv' p (MvPolynomial R β„š)).injective.commRing ghostFun ghostFun_zero ghostFun_one
262255
ghostFun_add ghostFun_mul ghostFun_neg ghostFun_sub ghostFun_nsmul ghostFun_zsmul
263256
ghostFun_pow ghostFun_natCast ghostFun_intCast

0 commit comments

Comments
Β (0)