Allow 128 explicitly: is this worth it?

grunweg · grunweg · commit 27643df1bee7 · 2024-06-30T10:56:02.000+02:00
diff --git a/scripts/lint_style.lean b/scripts/lint_style.lean
@@ -26,9 +26,10 @@ def lintStyleCli (args : Cli.Parsed) : IO UInt32 := do
   for s in ["Archive.lean", "Counterexamples.lean", "Mathlib.lean"] do
     let n ← lintAllFiles (System.mkFilePath [s]) errorStyle
     numberErrorFiles := numberErrorFiles + n
-  -- Make sure to return an exit code of at most 125, so this return value can be used further
-  -- in shell scripts.
-  return min numberErrorFiles 125
+  -- Make sure this return value can be used further in shell scripts:
+  -- exit codes 125 and 126 are disallowed, as is any number higher than 128.
+  if numberErrorFiles == 128 then return 128
+  else return min numberErrorFiles 125
 
 /-- Setting up command line options and help text for `lake exe lint_style`. -/
 -- so far, no help options or so: perhaps that is fine?
diff --git a/scripts/mk_all.lean b/scripts/mk_all.lean
@@ -68,9 +68,10 @@ def mkAllCLI (args : Parsed) : IO UInt32 := do
       updates := updates + 1
   if updates == 0 then
     IO.println "No update necessary"
-  -- Make sure to return an exit code of at most 125, so this return value can be used further
-  -- in shell scripts.
-  return min updates 125
+  -- Make sure this return value can be used further in shell scripts:
+  -- exit codes 125 and 126 are disallowed, as is any number higher than 128.
+  if updates == 128 then return 128
+  else return min updates 125
 
 open Cli in
 /-- Setting up command line options and help text for `lake exe mk_all`. -/
