Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

feat(analysis/normed_space/deriv): show that the differential is unique#830

Closed
jdsalchow wants to merge 10 commits intoleanprover-community:masterfrom
jdsalchow:differential_unique
Closed

feat(analysis/normed_space/deriv): show that the differential is unique#830
jdsalchow wants to merge 10 commits intoleanprover-community:masterfrom
jdsalchow:differential_unique

Conversation

@jdsalchow
Copy link
Copy Markdown
Collaborator

Show that the differential at a point is unique, if it is taken along a filter finer than the neighbourhood filter at the point.

This depends on #829 .

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list


/-- The differential of a map at a point along a filter is unique, given that filter is coarser than the
neighbourhood filter of the point.-/
lemma fderiv_at_filter_unique (f : E → F) (x₀ : E) {L : filter E} (h : nhds x₀ ≤ L) {A₁ A₂ : E → F} :
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make sure that the beginning and end of the proof are clearly identified? You are following mathlib style, sure, but I feel it is confusing. Maybe avoid blank lines in the middle of the proof (just adding -- on a blank line would help), and adding --end of proof at the end?

@jdsalchow jdsalchow force-pushed the differential_unique branch from 1f77b9e to 2d04a6c Compare March 30, 2019 18:34
avigad
avigad previously requested changes Apr 6, 2019
@jdsalchow jdsalchow requested a review from a team as a code owner April 7, 2019 22:00
@mergify mergify bot dismissed avigad’s stale review April 7, 2019 22:00

Pull request has been modified.

@sgouezel
Copy link
Copy Markdown
Collaborator

sgouezel commented Apr 9, 2019

Could you remove the empty lines in the proof of fderiv_at_filter_unique? If you want the travis tests to succeed, you should also PR this from a branch on community-mathlib. Otherwise, I think it is good to go, once you remove the redundant normed_field.norm_pow.

@jdsalchow
Copy link
Copy Markdown
Collaborator Author

I would re-PR this as from a branch on community-mathlib, but I don't think I have the permissions to do that ...

@jdsalchow
Copy link
Copy Markdown
Collaborator Author

I've re-PRd this as #916.

@jdsalchow jdsalchow closed this Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants