This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tweak some spacing, mark some theorems as
simp, and use auto-params for proofs ofset.nonemptywhen they can be deduced from the other arguments. We also movewell_founded.is_wfup in the file.My PR didn't break this (it was broken already), but it's still worth bringing up. Currently,
is_wf.minlooks messed up on the goal state: it renders as_.min _when the hypotheses aren't named. This could be fixed by also making the set an explicit argument, but I don't know if this inconvenience is worth it (there don't currently seem to be problems in inferring said argument).