This repository was archived by the owner on Jul 24, 2024. It is now read-only.
feat(tactic/ring, tactic/linarith): add reducibility parameter#1053
Closed
robertylewis wants to merge 2 commits intomasterfrom
Closed
feat(tactic/ring, tactic/linarith): add reducibility parameter#1053robertylewis wants to merge 2 commits intomasterfrom
robertylewis wants to merge 2 commits intomasterfrom
Conversation
Member
Author
|
I believe this will break a proof somewhere, the reason we originally changed these tactics to check for defeq instead of syntactic eq. Going to let Travis find where that happens. |
digama0
reviewed
May 19, 2019
src/tactic/ring.lean
Outdated
| This version of `ring` fails if the target is not an equality | ||
| that is provable by the axioms of commutative (semi)rings. -/ | ||
| meta def ring1 : tactic unit := | ||
| meta def ring1 (red : transparency) : tactic unit := |
Member
There was a problem hiding this comment.
This should also use parse (lean.parser.tk "!")? - ring1 is also a frontend tactic
Member
Author
|
Fixed. There's no broken proof, I guess that was resolved some other way. |
6 tasks
Member
Author
|
Subsumed by #1056 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slightly weakens the default behavior of
ringandlinarith. They will now only unfold reducible definitions when comparing atoms. Variantsring!andlinarith!will unfold semireducible definitions.TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list