Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(algebraic_geometry): comap of surjective homomorphism is closed embedding#15291

Closed
samvang wants to merge 18 commits intomasterfrom
closed_immersions
Closed

[Merged by Bors] - feat(algebraic_geometry): comap of surjective homomorphism is closed embedding#15291
samvang wants to merge 18 commits intomasterfrom
closed_immersions

Conversation

@samvang
Copy link
Copy Markdown
Collaborator

@samvang samvang commented Jul 13, 2022

The comap of a surjective homomorphism is a closed embedding between the Zariski spectra.

Co-authored-by: Jake Levinson @jakelev


Our first contribution to Mathlib ever (and my first pull request ever), written at Lean for the Curious Mathematician 2022 @ ICERM. Zulip chat.

Open in Gitpod

@samvang samvang changed the title Closed immersions Comap of surjective homomorphism is closed embedding Jul 13, 2022
Copy link
Copy Markdown
Collaborator

@tb65536 tb65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also want to add variables {S} at the top of this section.

@tb65536
Copy link
Copy Markdown
Collaborator

tb65536 commented Jul 13, 2022

When you want other people to look at this, you should mark this as "awaiting review"

@samvang samvang added the awaiting-review The author would like community review of the PR label Jul 13, 2022
@jcommelin
Copy link
Copy Markdown
Member

Congrats on your first PR!

Thanks for all the comments!

Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator Author

@samvang samvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakelev and I reviewed and committed the changes. Thanks for all the suggestions!

@samvang samvang changed the title Comap of surjective homomorphism is closed embedding feat(algebraic_geometry): comap of surjective homomorphism is closed embedding Jul 13, 2022
samvang added a commit that referenced this pull request Jul 13, 2022
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 16, 2022
samvang and others added 2 commits July 16, 2022 07:22
Co-authored-by: Johan Commelin <johan@commelin.net>
@samvang samvang added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 16, 2022
Co-authored-by: tb65536 <tb65536@users.noreply.github.com>
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-bot-assistant leanprover-community-bot-assistant added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 27, 2022
bors bot pushed a commit that referenced this pull request Jul 27, 2022
…embedding (#15291)

The comap of a surjective homomorphism is a closed embedding between the Zariski spectra.

Co-authored-by: Jake Levinson @jakelev 



Co-authored-by: Jake Levinson <levinson.jake@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Jul 27, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebraic_geometry): comap of surjective homomorphism is closed embedding [Merged by Bors] - feat(algebraic_geometry): comap of surjective homomorphism is closed embedding Jul 27, 2022
@bors bors bot closed this Jul 27, 2022
@bors bors bot deleted the closed_immersions branch July 27, 2022 17:02
bottine pushed a commit to bottine/mathlib that referenced this pull request Jul 30, 2022
…embedding (leanprover-community#15291)

The comap of a surjective homomorphism is a closed embedding between the Zariski spectra.

Co-authored-by: Jake Levinson @jakelev 



Co-authored-by: Jake Levinson <levinson.jake@gmail.com>
robertylewis pushed a commit that referenced this pull request Aug 2, 2022
…embedding (#15291)

The comap of a surjective homomorphism is a closed embedding between the Zariski spectra.

Co-authored-by: Jake Levinson @jakelev 



Co-authored-by: Jake Levinson <levinson.jake@gmail.com>
khwilson pushed a commit that referenced this pull request Aug 2, 2022
…embedding (#15291)

The comap of a surjective homomorphism is a closed embedding between the Zariski spectra.

Co-authored-by: Jake Levinson @jakelev 



Co-authored-by: Jake Levinson <levinson.jake@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants