feat: upstream exact? and apply?#343
Closed
kim-em wants to merge 4 commits intoleanprover-community:mainfrom
Closed
feat: upstream exact? and apply?#343kim-em wants to merge 4 commits intoleanprover-community:mainfrom
kim-em wants to merge 4 commits intoleanprover-community:mainfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At @joehendrix's suggestion I am opening a PR for
exact?andapply?.I don't think we're quite ready to do this as an atomic PR, so for now just consider this as a draft, so we can see what remains to be done.
We may want to substantially rewrite parts of this code --- although it's not quite as bad as I remember it being. :-)
exact?test suite is very Mathlib specific, so we would need to write a new one for Std.Std.Tactic.LibrarySearch.cachePathhas a hard-coded Mathlib-specific path! This is because thecacheinfrastructure, which is essential for runningexact?quickly at Mathlib scale, only exists in Mathlib!